IAttribute and ICharTermAttribute method changes, #1038

[paulirwin]

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Remove SetLength and SetEmpty from ICharTermAttribute and moves them to extension methods. Add Clear() in place of SetEmpty.

Fixes #1038

Description

See the rationale in #1038.

This PR makes the following breaking changes:

• Removes SetLength and SetEmpty from ICharTermAttribute, moves them to extensions instead.
• Adds the Clear method to ICharTermAttribute.
• Removes the CopyTo method from IAttribute.

[NightOwl888]

Thanks for the PR.

Looks good except it is missing the implementation of the SetLength() extension method and SetLength() hasn't been removed from CharTermAttribute. See the inline comments.

[NightOwl888]

I agree. Putting the Clear() method on ICharTermAttribute seems to be the best solution.

However, there is some cleanup left to do. Please see the inline comments.