[Refactor] Reduce redundancy by introducing consistent functional interface in SessionConnection #14212
+132
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, William! Great work on this pull request! Your approach and the implementation are impressive, and it's clear that a lot of thought and effort went into solving the problem effectively. While I noticed that the CI checks haven't passed, I have full confidence in the correctness of your changes. The approach you've taken is solid and aligns well with the project’s goals. Given the quality of the code and the improvements you have made, I'm happy to approve this PR. 🥰🥰 Looking forward to seeing more contributions from you! Keep up the great work, and I’m excited to review more of your PRs in the future. 🔥🔥🚀 |
|
William - YOU ARE TRULY AN ASSET TO THE APACHE IOTDB！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SessionConnection has 26 times of redundant control clauses.
We can unify them by introducing a CheckedSupplier.
This is a WIP for demo.