Add Binary Allocator #14201
Open
Add Binary Allocator #14201
+1,432
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private int sampleCount; | ||
| private final int weight; | ||
| private boolean isOld; // Enable to have enough historical data | ||
| private final int OLD_THRESHOLD = 100; |
...ns/src/main/java/org/apache/iotdb/commons/utils/binaryallocator/AdaptiveWeightedAverage.java
Show resolved
Hide resolved
...ns/src/main/java/org/apache/iotdb/commons/utils/binaryallocator/AdaptiveWeightedAverage.java
Show resolved
Hide resolved
| /** The default value for {@code evictorShutdownTimeout} configuration attribute. */ | ||
| private long evictorShutdownTimeoutMillis = 10L * 1000L; | ||
|
|
||
| /** The default value for {@code evictorShutdownTimeout} configuration attribute. */ |
There was a problem hiding this comment.
Please describe the meaning of these parameters in the Javadoc. The way it is written now is worse than not writing it at all...
| private int[] sizeIdx2sizeTab; | ||
| final int lookupMaxSize; | ||
|
|
||
| final int LOG2_QUANTUM; |
There was a problem hiding this comment.
why not private？
There was a problem hiding this comment.
Do not capitalize variables that are not final static...
|
|
||
| public PooledBinary allocateBinary(int reqCapacity) { | ||
| if (reqCapacity < allocatorConfig.minAllocateSize | ||
| | reqCapacity > allocatorConfig.maxAllocateSize) { |
| state.set(BinaryAllocatorState.OPEN); | ||
| evictor = | ||
| new GCEvictor( | ||
| "binary-allocator-gc-evictor", allocatorConfig.getDurationEvictorShutdownTimeout()); |
There was a problem hiding this comment.
do no use magic string
| } | ||
|
|
||
| public void close(boolean needReopen) { | ||
| if (needReopen) state.set(BinaryAllocatorState.TMP_CLOSE); |
|
|
||
| package org.apache.iotdb.commons.utils.binaryallocator; | ||
|
|
||
| public enum BinaryAllocatorState { |
There was a problem hiding this comment.
Describe the transition relationship between these states, and what conditions trigger the transition
| AllocatorConfig config = new AllocatorConfig(); | ||
| config.arenaNum = 1; | ||
| BinaryAllocator binaryAllocator = new BinaryAllocator(config); | ||
| PooledBinary binary = binaryAllocator.allocateBinary(256); |
There was a problem hiding this comment.
use Odd number like 255 is better to test jvm allocation？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Binary Allocator for object pooling and reuse of large Binary objects to reduce GC overhead.
Features
Details
Next Steps
Integrate Binary Allocator into IoTDB's writing execution.