Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 #11351

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

qy-liuhuo
Copy link
Contributor

@qy-liuhuo qy-liuhuo commented Oct 13, 2024

Fixes #11349

Motivation

Integrate opentelemetry for sort-connectors-v1.15

Modifications

Integrate opentelemetry for:

  • sort-connector-iceberg-v1.15
  • sort-connector-kafka-v1.15
  • sort-connector-mysql-cdc-v1.15
  • sort-connector-pulsar-v1.15

However, some connectors that do not conform to the FLIP-27 have not yet been integrated

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang requested review from XiaoYou201 and vernedeng and removed request for XiaoYou201 October 13, 2024 13:56
@qy-liuhuo
Copy link
Contributor Author

When integrating sort-connector-kafka-v1.15 and sort-connector-pulsar-v1.15, the unit test fails. I currently think it is a Maven dependency issue, which I will try to resolve later.

vernedeng
vernedeng previously approved these changes Nov 18, 2024
@aloyszhang aloyszhang self-requested a review November 24, 2024 03:59
@aloyszhang
Copy link
Contributor

aloyszhang commented Nov 24, 2024

Thanks for your contribution.
Sorry, but If we don't use the open telemetry, why do we initialize it in the open method?
Maybe adding a new configuration to enable open telemetry is better?

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adding a new configuration to enable opentelemetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Integrate opentelemetry for sort-connectors-v1.15
5 participants