-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add fastjson2 serializer support #6904
Open
GoodBoyCoder
wants to merge
13
commits into
apache:2.x
Choose a base branch
from
GoodBoyCoder:feature-fastjson2-serial
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: feature
Category issues or prs related to feature request.
module/rm-datasource
rm-datasource module
module/serializer
serializer module
labels
Oct 9, 2024
funky-eyes
reviewed
Oct 9, 2024
core/src/main/java/org/apache/seata/core/serializer/SerializerType.java
Outdated
Show resolved
Hide resolved
...astjson2/src/main/java/org.apache.seata.serializer.fastjson2/Fastjson2SerializerFactory.java
Outdated
Show resolved
Hide resolved
...lizer-fastjson2/src/main/java/org.apache.seata.serializer.fastjson2/Fastjson2Serializer.java
Outdated
Show resolved
Hide resolved
…eature-fastjson2-serial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6904 +/- ##
============================================
+ Coverage 52.53% 52.55% +0.01%
- Complexity 6541 6549 +8
============================================
Files 1122 1124 +2
Lines 39858 39872 +14
Branches 4666 4666
============================================
+ Hits 20940 20955 +15
+ Misses 16925 16922 -3
- Partials 1993 1995 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/rm-datasource
rm-datasource module
module/serializer
serializer module
type: feature
Category issues or prs related to feature request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
支持 fastJson2序列化RPC消息
Support fastJson2 serialization of RPC messages
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Configure the serialization method to fastjson2
Ⅴ. Special notes for reviews
关于是否统一序列化类型为FastJson(即去除fastjson1,统一采用fastjson2),这个很大程度依赖与fastjson2的兼容性,undolog的对象结构复杂,大概率做不到100%兼容,故这里应该需要区分fastjson1和fastjson2,而如果RPC统一为fastjson,两边的配置叫法就不是很统一
Whether to unify the serialization type to FastJson (i.e., remove fastjson1 and unify to fastjson2) depends largely on the compatibility with fastjson2. The object structure of undolog is complex and it is highly unlikely to be 100% compatible. Therefore, it is necessary to distinguish between fastjson1 and fastjson2. If RPC is unified as fastjson, the configuration names on both sides will not be very unified.