feature: seata-server support http protocol #6801

PleaseGiveMeTheCoke · 2024-08-31T16:03:38Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

support http protocol

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

2. support multi-version

…GrpcMessageProto.java

…GrpcMessage.java

…SeataServiceGrpc.java

…seata/serializer/protobuf/GrpcSerializer.java

…GrpcMessageProtoOrBuilder.java

# Conflicts: # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java

codecov · 2024-10-12T00:44:44Z

Codecov Report

Attention: Patch coverage is 25.81967% with 181 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (fabccea) to head (043df21).

Files with missing lines	Patch %	Lines
...che/seata/core/rpc/netty/http/ParameterParser.java	0.00%	43 Missing ⚠️
...ata/core/rpc/netty/http2/Http2DispatchHandler.java	0.00%	36 Missing ⚠️
...seata/core/rpc/netty/http/HttpDispatchHandler.java	0.00%	33 Missing ⚠️
...seata/core/rpc/netty/http2/Http2DetectHandler.java	0.00%	14 Missing ⚠️
...ache/seata/core/rpc/netty/http/HttpInvocation.java	0.00%	13 Missing ⚠️
...che/seata/core/protocol/detector/HttpDetector.java	15.38%	11 Missing ⚠️
...pache/seata/core/rpc/netty/http/ParamMetaData.java	0.00%	8 Missing ⚠️
.../server/cluster/manager/ClusterWatcherManager.java	0.00%	6 Missing ⚠️
...e/seata/server/controller/ClusterV2Controller.java	14.28%	6 Missing ⚠️
...e/seata/core/rpc/netty/http/ControllerManager.java	0.00%	5 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6801      +/-   ##
============================================
+ Coverage     52.53%   52.59%   +0.05%     
- Complexity     6541     6553      +12     
============================================
  Files          1122     1130       +8     
  Lines         39858    39861       +3     
  Branches       4666     4657       -9     
============================================
+ Hits          20940    20965      +25     
+ Misses        16925    16907      -18     
+ Partials       1993     1989       -4

Files with missing lines	Coverage Δ
...in/java/org/apache/seata/common/DefaultValues.java	`0.00% <ø> (ø)`
...he/seata/core/rpc/netty/ProtocolDetectHandler.java	`63.15% <100.00%> (ø)`
...eata/namingserver/controller/NamingController.java	`38.88% <ø> (ø)`
...he/seata/core/protocol/detector/Http2Detector.java	`31.25% <0.00%> (+3.47%)`	⬆️
...e/seata/core/rpc/netty/http/ControllerManager.java	`0.00% <0.00%> (ø)`
...er/spring/web/RestControllerBeanPostProcessor.java	`92.18% <92.18%> (ø)`
.../server/cluster/manager/ClusterWatcherManager.java	`30.00% <0.00%> (ø)`
...e/seata/server/controller/ClusterV2Controller.java	`14.28% <14.28%> (ø)`
...pache/seata/core/rpc/netty/http/ParamMetaData.java	`0.00% <0.00%> (ø)`
...che/seata/core/protocol/detector/HttpDetector.java	`15.38% <15.38%> (ø)`
... and 5 more

... and 6 files with indirect coverage changes

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

core/src/main/java/org/apache/seata/core/rpc/netty/http/ParameterParser.java

funky-eyes · 2024-10-13T06:46:25Z

core/src/main/java/org/apache/seata/core/rpc/netty/http2/Http2DispatchHandler.java

+    @Override
+    public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
+        if (msg instanceof Http2HeadersFrame) {
+            if (headerSent.compareAndSet(false, true)) {


这个连接如果一直被复用,但是没有开启双向流的形式,使用http2传递不同的header,但是这里只读了一次,会不会有问题?
If this connection has been reused all the time, but the form of bidirectional streaming is not enabled, using HTTP2 to pass different headers, but only read it once, will there be a problem?

unary模式的话，每次都会开启一条新的流，channel和handler都会创建新的

core/src/main/java/org/apache/seata/core/rpc/netty/http2/Http2DispatchHandler.java

...a-serializer-protobuf/src/main/java/org/apache/seata/serializer/protobuf/GrpcSerializer.java

funky-eyes · 2024-10-13T06:50:07Z

server/src/main/java/org/apache/seata/server/cluster/manager/ClusterWatcherManager.java

@@ -86,6 +91,16 @@ public void onChangeEvent(ClusterChangeEvent event) {
    }

    private void notify(Watcher<?> watcher) {
+        Channel channel  = (Channel) watcher.getAsyncContext();
+        if (channel instanceof Http2StreamChannel) {


http1的呢?如果通过8091端口进来的v1/watch,可不是下面的HttpServletResponse逻辑能正常执行的
What about HTTP1? If v1/watch comes in through port 8091, the following HttpServletResponse logic can not be executed normally

server/src/main/java/org/apache/seata/server/controller/ClusterController.java

common/pom.xml

common/src/main/java/org/apache/seata/common/DefaultValues.java

common/src/main/java/org/apache/seata/common/util/Http2ClientUtil.java

funky-eyes · 2024-10-14T09:36:18Z

server/src/main/java/org/apache/seata/server/controller/ClusterController.java

@@ -55,7 +56,7 @@
 /**
 */
 @RestController
-@RequestMapping("/metadata/v1")
+@RequestMapping("/metadata")


为什么去除这里的v1，而在下面给每一个增加v1？

server/src/main/java/org/apache/seata/server/controller/ClusterController.java

...ery-raft/src/main/java/org/apache/seata/discovery/registry/raft/RaftRegistryServiceImpl.java

server/src/main/java/org/apache/seata/server/cluster/manager/ClusterWatcherManager.java

…to http_support � Conflicts: � discovery/seata-discovery-raft/src/main/java/org/apache/seata/discovery/registry/raft/RaftRegistryServiceImpl.java

funky-eyes

新增的配置项需要在https://github.com/apache/incubator-seata/tree/2.x/script/client 中的spring和file中添加示例

funky-eyes · 2024-10-18T12:49:16Z

common/src/main/java/org/apache/seata/common/ConfigurationKeys.java

+    /**
+     * http1 or http2
+     */
+    String HTTP_VERSION = TRANSPORT_PREFIX + "httpVersion";


应该放到registry.raft下面,而不是transport

PleaseGiveMeTheCoke and others added 30 commits August 14, 2024 08:06

grpc protocol

e96ea17

grpc protocol

2e9d232

grpc protocol

be0448a

grpc protocol

6cbbac0

grpc protocol

bea5592

Merge branch '2.x' into grpc_support

c970d20

delete no need change

899f490

Merge remote-tracking branch 'origin/grpc_support' into grpc_support

44675d9

cr

5bf5038

1. mock test

548fa42

2. support multi-version

cr

1e9a0c2

cr

c4e0bc4

Delete seata-test-grpc/src/main/java/org/apache/seata/grpc/generated/…

24c0d23

…GrpcMessageProto.java

Delete seata-test-grpc/src/main/java/org/apache/seata/grpc/generated/…

4e2fe65

…GrpcMessage.java

Delete seata-test-grpc/src/main/java/org/apache/seata/grpc/generated/…

022b9cb

…SeataServiceGrpc.java

Delete serializer/seata-serializer-protobuf/src/main/java/org/apache/…

a7762a2

…seata/serializer/protobuf/GrpcSerializer.java

Delete seata-test-grpc/src/main/java/org/apache/seata/grpc/generated/…

0ba622c

…GrpcMessageProtoOrBuilder.java

cr

397b90c

Merge remote-tracking branch 'origin/grpc_support' into grpc_support

4d36883

Merge branch '2.x' into grpc_support

f71391b

cr

05552c0

Merge remote-tracking branch 'origin/grpc_support' into grpc_support

6dbefc3

# Conflicts: # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java

cr

c7da0ff

Merge branch '2.x' into grpc_support

6b04158

cr

b93add1

Merge remote-tracking branch 'origin/grpc_support' into grpc_support

e1b7409

cr

e45049c

cr

0621acd

cr

06dfe34

cr

c701a79

PleaseGiveMeTheCoke added 3 commits October 10, 2024 08:38

http2 watch

c909cc2

http2 watch

02d732c

http2 watch

094a82c

funky-eyes and others added 5 commits October 12, 2024 16:21

Merge branch '2.x' into http_support

6a950fa

http2 watch

b718a5a

Merge remote-tracking branch 'origin/http_support' into http_support

cd23d21

http2 watch

c503e32

http2 watch

6d94a2c

funky-eyes reviewed Oct 13, 2024

View reviewed changes

http2 watch

8b68d8a

funky-eyes reviewed Oct 14, 2024

View reviewed changes

common/pom.xml Show resolved Hide resolved

common/src/main/java/org/apache/seata/common/DefaultValues.java Outdated Show resolved Hide resolved

funky-eyes reviewed Oct 14, 2024

View reviewed changes

server/src/main/java/org/apache/seata/server/cluster/manager/ClusterWatcherManager.java Outdated Show resolved Hide resolved

PleaseGiveMeTheCoke added 5 commits October 15, 2024 08:35

http2 watch

5d77fd9

http2 watch

1a3a6fa

Merge branch '2.x' of https://github.com/PleaseGiveMeTheCoke/seata in…

1f75bd2

…to http_support � Conflicts: � discovery/seata-discovery-raft/src/main/java/org/apache/seata/discovery/registry/raft/RaftRegistryServiceImpl.java

http2 watch

d578520

http2 watch

7eb6530

funky-eyes reviewed Oct 18, 2024

View reviewed changes

PleaseGiveMeTheCoke and others added 9 commits October 18, 2024 23:14

http2 watch

62f1279

http2 watch

5d24f0e

http2 watch

1b7ecb5

http2 watch

c1da7ad

http2 watch

986418d

http2 watch

8db87a0

http2 watch

95ec3e2

http2 watch

5fff774

Merge branch '2.x' into http_support

043df21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: seata-server support http protocol #6801

feature: seata-server support http protocol #6801

PleaseGiveMeTheCoke commented Aug 31, 2024

codecov bot commented Oct 12, 2024 •

edited

Loading

funky-eyes Oct 13, 2024

PleaseGiveMeTheCoke Oct 13, 2024

funky-eyes Oct 13, 2024

funky-eyes Oct 14, 2024

funky-eyes left a comment

funky-eyes Oct 18, 2024

feature: seata-server support http protocol #6801

Are you sure you want to change the base?

feature: seata-server support http protocol #6801

Conversation

PleaseGiveMeTheCoke commented Aug 31, 2024

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov bot commented Oct 12, 2024 • edited Loading

Codecov Report

funky-eyes Oct 13, 2024

Choose a reason for hiding this comment

PleaseGiveMeTheCoke Oct 13, 2024

Choose a reason for hiding this comment

funky-eyes Oct 13, 2024

Choose a reason for hiding this comment

funky-eyes Oct 14, 2024

Choose a reason for hiding this comment

funky-eyes left a comment

Choose a reason for hiding this comment

funky-eyes Oct 18, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 12, 2024 •

edited

Loading