Snapshot summary map must have operation key
#11354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional constraints in the
SnapshotParserand also includes tests to verify the behaviors.Snapshot'ssummaryfield is optional in V1 but required in V2. See https://iceberg.apache.org/spec/#snapshotsWhen serializing
SnapshottoJSON, if thesummaryfield exists, theoperationkey must also exist (code). In other words, thesummaryfield without theoperationkey is considered invalid.Devlist discussion https://lists.apache.org/thread/h9qmrmlgxh91ol0y2v8olt90b9q6p9xr
Relates to apache/iceberg-python/#1106