Core: delete temp metadata file when version already exists #11350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdblue please help to review this PR, thanks. |
nastra
reviewed
Oct 18, 2024
| throw new CommitFailedException("Version %d already exists: %s", nextVersion, dst); | ||
| CommitFailedException cfe = | ||
| new CommitFailedException("Version %d already exists: %s", nextVersion, dst); | ||
| RuntimeException re = tryDelete(src); |
There was a problem hiding this comment.
is it always correct to delete the src file or could there be cases where we'd want to keep it?
There was a problem hiding this comment.
@nastra yes, i think it is always safe to delete the temp src file(temp metadata file), the commit retry would create a new temp metadata file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HadoopCatalog, renameToFinal would fail with version already exists exception, we should also delete the temp metadata file in this case.