HIVE-28537: Iceberg: allow only partition columns in the WHERE clause #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difin
reviewed
Oct 3, 2024
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
Outdated
Show resolved
Hide resolved
difin
reviewed
Oct 3, 2024
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
Outdated
Show resolved
Hide resolved
difin
reviewed
Oct 3, 2024
difin
reviewed
Oct 3, 2024
difin
reviewed
Oct 3, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactAnalyzer.java
Outdated
Show resolved
Hide resolved
|
+1, Looks good to me. Added a few minor formatting comments. |
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
ad45a83
to
51d4295
Compare
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
2 times, most recently
from
63ad837
to
ed57046
Compare
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
difin
reviewed
Oct 7, 2024
.../src/test/queries/positive/iceberg_major_compaction_partition_evolution_w_id_spec_w_filter.q
Outdated
Show resolved
Hide resolved
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
ed57046
to
5143c61
Compare
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
5143c61
to
b9fba8b
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
deniskuzZ
reviewed
Oct 17, 2024
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2024
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
Outdated
Show resolved
Hide resolved
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
62b9eaa
to
0cd38de
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
deniskuzZ
reviewed
Oct 18, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 18, 2024
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 18, 2024
|
please address only relevant items from https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5483&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true |
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
0cd38de
to
8efb17f
Compare
|
@deniskuzZ thanks for the review! Please check the modifications! |
Change-Id: Ic85efd70599413cdb96073c6cb50690fbc1c11b0
zratkai
force-pushed
the
HIVE-28537-only-partcol-compaction
branch
from
8efb17f
to
f7f2eb4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic85efd70599413cdb96073c6cb50690fbc1c11b0
What changes were proposed in this pull request?
Limiting the columns in where clause in compaction to partition columns.
Why are the changes needed?
Currently Hive Iceberg compaction supports any columns in the WHERE clause predicate. However, compaction happens only on partition level. Performance can be improved if the columns in WHERE clause predicate will be limited to partition columns.
Does this PR introduce any user-facing change?
Yes, user will get an exception if uses non partition columns in alter table compaction query.
Is the change a dependency upgrade?
No.
How was this patch tested?
With qtest.