Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18033. [WIP] Remove jsr311-api dependency #4460

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

virajjasani
Copy link
Contributor

Description of PR

More discussion on HADOOP-18033

@virajjasani virajjasani changed the title Remove jsr311-api dependency HADOOP-18033. Remove jsr311-api dependency Jun 18, 2022
@virajjasani virajjasani changed the title HADOOP-18033. Remove jsr311-api dependency HADOOP-18033. Remove jsr311-api dependency (ADDENDUM) Jun 18, 2022
@virajjasani virajjasani changed the title HADOOP-18033. Remove jsr311-api dependency (ADDENDUM) HADOOP-18033. Remove jsr311-api dependency Jun 18, 2022
@ayushtkn
Copy link
Member

Build kind of died only. Guess the test failures screwed the build in some way, We already know something will break, just wanted to know what all break and how big is the impact....

@virajjasani
Copy link
Contributor Author

Exactly, I wish at least we could know all the failures (even though we know we are stuck with this dependency)

@virajjasani virajjasani changed the title HADOOP-18033. Remove jsr311-api dependency HADOOP-18033. Remove jsr311-api dependency [WIP] Jun 21, 2022
@virajjasani virajjasani changed the title HADOOP-18033. Remove jsr311-api dependency [WIP] HADOOP-18033. [WIP] Remove jsr311-api dependency Jun 21, 2022
@pjfanning
Copy link
Contributor

Looks like jersey-core:1.19 depends on jsr311-api and jsr311-api and rs-api cannot be on the classpath together because they clash.
So it looks like the new dependency on rs-api needs to be removed. This may not require jackson to be downgraded too.

@ayushtkn
Copy link
Member

@pjfanning Cool, if I understood correct, you mean: javax.ws.rs-api can be removed without Jackson downgrade.
Go ahead you can create a PR with that change, if things work fine then most probably we can save us from downgrading Jackson. :-)

@pjfanning
Copy link
Contributor

I have #4547 - let's see if that passes CI build

@virajjasani
Copy link
Contributor Author

So it looks like the new dependency on rs-api needs to be removed. This may not require jackson to be downgraded too.

javax.ws.rs-api was introduced only to support Jackson 2.13 upgrade. Without rs-api, (on Jackson 2.13) majority of Yarn and ATS tests fail as jackson 2.13 does have dependency on JAX-RS 2 based rs-api (PR #3749)

@pjfanning
Copy link
Contributor

@virajjasani I think FasterXML/jackson-jaxrs-providers#134 which appeared in jackson-jaxrs for v2.13.0 to be the reason rs-api was added to hadoop - so in #4547, I am looking to downgrade to jackson 2.12.7

@virajjasani
Copy link
Contributor Author

@virajjasani I think FasterXML/jackson-jaxrs-providers#134 which appeared in jackson-jaxrs for v2.13.0 to be the reason rs-api was added to hadoop - so in #4547, I am looking to downgrade to jackson 2.12.7

Exactly, without downgrading Jackson, it's not possible to remove javax.ws.rs-api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants