Update to OpenJDK11 in Docker image #2433

eolivelli · 2020-10-08T13:35:57Z

Descriptions of the changes in this PR:

Update "master" docker image to BK 4.11.0
Update to OpenJDK11 the main Docker image and the Docker image used for integration tests
We are not using "JRE" because it does not bundle jshell and our script detects the presence of JDK11+ from the presence of file "jshell"

Master Issue: #2387

eolivelli · 2020-10-08T13:56:26Z

@ravisharda @sijie please take a look.
With this change the new Docker images should use JDK11.

Integration tests are passing, they are not using the 'official' image but this one
https://github.com/apache/bookkeeper/pull/2433/files#diff-703a1f3a859eee31b4105dee51812399R33

that uses JDK11 as well

ravisharda · 2020-10-09T08:58:33Z

docker/Dockerfile

@@ -20,20 +20,20 @@
 FROM centos:7
 MAINTAINER Apache BookKeeper <[email protected]>

-ARG BK_VERSION=4.9.0
+ARG BK_VERSION=4.11.0


This also upgrades the image to use 4.11.0, apart from changing the Java version. Would it make sense to separate the two and merge it to older release lines, so that users using older versions of Bookkeeper like v4.9.2 can also benefit from the Java upgrade?

I am not sure that the bash files on 4.9.2 work with java11 due to removed JVM command line flags.

4.10 should work.

Btw we are close to releasing 4.12 so 4.9 is becoming far distant from current versions

Also It would be better to use the version in pom files and in current master it should be 4.12.0-SNAPSHOT but if I change it the image cannot be built so currently I can only use this version.
We are in the middle of the process of releasing 4 11.1 so probably we will set 4.11.1 here on current master.

Another solution would be to pick the binaries from local filesystem if the version is a SNAPSHOT

This is my fix for using JRE
that said, it won't be available to old BK versions
#2436

with BK 4.12.0 we will be able to use JRE 11

ravisharda · 2020-10-09T09:14:10Z

docker/README.md

@@ -13,7 +13,7 @@ Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve
 Just like running a BookKeeper cluster in one machine(http://bookkeeper.apache.org/docs/latest/getting-started/run-locally/), you can run a standalone BookKeeper in one docker container, the command is:
 ```
 docker run -it \
-     --env JAVA_HOME=/usr/lib/jvm/jre-1.8.0 \
+     --env JAVA_HOME=/usr/lib/jvm/jdk-11 \


Should we install the JRE instead? I suppose installing JDK instead of JRE would increase the image size. I'm not sure whether that increase in size is significant in relation to the overall image size or not. What are your thoughts about this?

I would like, but in current 4.11 we are using the presence of shell to detect jdk11 and it is not present in the.

We should fix that problem, then we can use the jre.

Btw I don't know a good way to detect jdk11+

@ravisharda here it is a fix to support JRE and only only JDK
#2436

ravisharda · 2020-10-13T02:25:46Z

@eolivelli based on the above conversations, I understand that this PR shall upgrade both Bookkeeper (to 4.11.0) and Java (to Java 11), and is it not desirable to separate the two. Pravega is now on Java 11, so the latter should be fine.

As for Bookkeeper, it uses 4.9.2, so this solution wouldn't work for it as is. I suppose, Pravega should also upgrade its Bookkeeper dependency to 4.11.0 to benefit from this, which looks OK to me, given that you see 4.9.x as an old version now. Curious, does Bookkeeper server 4.11.0 continue to work with older Bookkeeper clients (4.9.2, etc.)?

eolivelli · 2020-10-13T12:46:36Z

does Bookkeeper server 4.11.0 continue to work with older Bookkeeper clients (4.9.2, etc.)?

@ravisharda sure ! we have integration tests for very old clients

ravisharda · 2020-10-14T16:00:47Z

@eolivelli The documentation at https://bookkeeper.apache.org/ mentions 4.9.2 as the last stable version.

Is version 4.11.0 (or 4.10 if we use that version instead) considered stable version too? If yes, the documentation might need an update. If no, I believe a Docker image that supports 4.9.2 and uses JDK 11 may be needed too.

eolivelli · 2020-10-14T16:10:56Z

Yes 4.11 can be considered "stable" from my point of view.
We are currently releasing the first bugfix release 4.11.1, but it is not about regressions, only new goodies :-)

We are working on a new website, and current one is outdated.

We already released 4.10 "major" release, and 4.11 and we are going to release 4.12, so this is why I am telling that 4.9 is quite old, because it distant from the current active branches.
In the products of my company (EmailSuccess, HerdDB...) we are running 4.10 or 4.11, and AFAIK Apache Pulsar is on 4.10

ravisharda

LGTM.

Descriptions of the changes in this PR: - Update "master" docker image to BK 4.11.0 - Update to OpenJDK11 the main Docker image and the Docker image used for integration tests - We are not using "JRE" because it does not bundle jshell and our script detects the presence of JDK11+ from the presence of file "jshell" Master Issue: #2387 Reviewers: Ravi Sharda <None>, Jia Zhai <[email protected]> This closes #2433 from eolivelli/fix/test-jdk11-upgrade-docker (cherry picked from commit 83dec6e) Signed-off-by: Enrico Olivelli <[email protected]>

Update to OpenJDK11 in Docker image

f07b483

eolivelli mentioned this pull request Oct 8, 2020

Security vulnerabilities in the apache/bookkeeper-4.9.2 image #2387

Closed

eolivelli requested a review from sijie October 8, 2020 13:55

eolivelli marked this pull request as draft October 8, 2020 15:00

eolivelli added 3 commits October 8, 2020 17:13

update jre11 path

5ce69bf

use JDK11 and not JRE

5d45cdc

more changes

c1199d1

eolivelli marked this pull request as ready for review October 8, 2020 15:23

ravisharda suggested changes Oct 9, 2020

View reviewed changes

eolivelli requested review from jiazhai and rdhabalia October 13, 2020 12:47

ravisharda approved these changes Oct 15, 2020

View reviewed changes

jiazhai approved these changes Oct 15, 2020

View reviewed changes

eolivelli added this to the 4.12.0 milestone Oct 16, 2020

eolivelli added area/docker release/4.12.0 type/improvement labels Oct 16, 2020

eolivelli self-assigned this Oct 16, 2020

eolivelli merged commit 83dec6e into apache:master Oct 16, 2020

eolivelli added the release/4.11.2 label Oct 16, 2020

eolivelli deleted the fix/test-jdk11-upgrade-docker branch October 16, 2020 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to OpenJDK11 in Docker image #2433

Update to OpenJDK11 in Docker image #2433

eolivelli commented Oct 8, 2020 •

edited

Loading

eolivelli commented Oct 8, 2020

ravisharda Oct 9, 2020

eolivelli Oct 9, 2020

eolivelli Oct 9, 2020

eolivelli Oct 11, 2020

ravisharda Oct 9, 2020

eolivelli Oct 9, 2020

eolivelli Oct 12, 2020

ravisharda commented Oct 13, 2020 •

edited

Loading

eolivelli commented Oct 13, 2020

ravisharda commented Oct 14, 2020 •

edited

Loading

eolivelli commented Oct 14, 2020

ravisharda left a comment

Update to OpenJDK11 in Docker image #2433

Update to OpenJDK11 in Docker image #2433

Conversation

eolivelli commented Oct 8, 2020 • edited Loading

eolivelli commented Oct 8, 2020

ravisharda Oct 9, 2020

Choose a reason for hiding this comment

eolivelli Oct 9, 2020

Choose a reason for hiding this comment

eolivelli Oct 9, 2020

Choose a reason for hiding this comment

eolivelli Oct 11, 2020

Choose a reason for hiding this comment

ravisharda Oct 9, 2020

Choose a reason for hiding this comment

eolivelli Oct 9, 2020

Choose a reason for hiding this comment

eolivelli Oct 12, 2020

Choose a reason for hiding this comment

ravisharda commented Oct 13, 2020 • edited Loading

eolivelli commented Oct 13, 2020

ravisharda commented Oct 14, 2020 • edited Loading

eolivelli commented Oct 14, 2020

ravisharda left a comment

Choose a reason for hiding this comment

eolivelli commented Oct 8, 2020 •

edited

Loading

ravisharda commented Oct 13, 2020 •

edited

Loading

ravisharda commented Oct 14, 2020 •

edited

Loading