Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25993: logsearch-logfeeder cannot startup due to lake of configuration #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rzuo
Copy link
Contributor

@rzuo rzuo commented Aug 19, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

logsearch-logfeeder fail to startup and report:
java.lang.IllegalArgumentException: String 'null' cannot be converted to LogFeederMode enum
image

Due to the lake of configuration item logfeeder.cloud.storage.mode in configuration.
We need to fall back to Default("default") without this configuration, so logfeeder can startup normally.

After the fix, logfeeder startup normally, and can feed log data to logsearch-portal.

How was this patch tested?

local install and test this fix in local cluster.

image

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

}
} catch (IllegalArgumentException e) {
return LogFeederMode.DEFAULT;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzuo Can we add some logging here to indicate this configuration exception and the fallback to using the default configuration? This would help users troubleshoot issues more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants