OpenStack - Improve connection check after instance creation #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Wait for SSH
task in thecreate.yml
playbook makes some assumptions:Both of them are not always true, especially the first one. Especially in cloud environments a bastion node / jumphost is used very often to connect to the VMs. Such a scenario can't be used with the current implementation.
Therefore I would suggest to move this task to the
prepare.yml
playbook. We can usewait_for_connection
then, which respects the ssh config (jumphost, ports, ...) and the ansible config for these hosts. So both described use cases are now possible.This can break existing configurations, if the
prepare.yml
is overridden within the actual molecule test.