[PR #992/e3b36e5f backport][stable-3] module docker_compose_v2_run: fix env argument #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* module docker_compose_v2_run: fix env argument * fix missing "--env" in docker_compose_v2_exec, and added changelog fragment * Update changelogs/fragments/992-module-docker_compose_v2_run-fix-env-argument.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e3b36e5)
felixfontein
deleted the
patchback/backports/stable-3/e3b36e5f0a12d8fe86a659f06fa035a1628b16ea/pr-992
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #992 as merged into main (e3b36e5).
SUMMARY
In the get_run_cmd definition, the self.env loop adds --env before every argument while iterating through.
ISSUE TYPE
COMPONENT NAME
docker_compose_v2_run
ADDITIONAL INFORMATION
Without the additional change, it cannot take arguments as variables and fails.
failed.log
succes.log