-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #309 #310
Fixes #309 #310
Conversation
I like it but the releases are broken and we don't know why and I don't have time to debug. see failed releases https://github.com/anothrNick/github-tag-action/actions/workflows/main.yml |
@sbe-arg In any case: the Bump CI job does work on my own repo, so changes to the yaml manifests should not be needed. It might be worth checking if "read and write permissions" are enabled? PD: For my specific usecase a release is not needed, I will pin the commit hash regardless. |
Any of those repo config changes are only allowed by @anothrNick wich has been tagged in this issue/problem before. Also is unclear why we suddenly started having this problem. Its hard to "test" this myself is something on hands of @anothrNick to fix atm 🤷♂️ |
Settings all look right on this repo, I've also confirmed that the latest commit on master, as well as the other configuration options within the workflow, work fine in another repo... I'll keep reading around a bit today, really not sure whats going on. |
Made a change to our workflow using That would explain why it is working in contributors' repos but not when its PR'd here. I also wonder if this just started popping up due to timing with:
Either way, I'm going to merge this PR and see if it works. |
@druskus20 can you resubmit this PR? I didn't update the |
Summary of changes
Breaking Changes
NO
Since I added a new argument (FORCE_WITHOUT_CHANGES_PRE), there shouldn't be any.
Alternatively, we can use FORCE_WITHOUT_CHANGES for prereleases as well, which would imply a breaking change.
How changes have been tested
I've tried the fork on a private repo. It works as expected. The changes are also minimal so they should be fine.
List any unknowns