Issue #24 #30
Issue #24 #30
Conversation
|
@forsd Are you able to set up this project on your system ? |
|
Sure. |
|
Is it working perfectly on your system ? |
|
Register, login, chat working. No errors occured. |
|
Anything that isn't working, You can open issues here, I'll check out the PR tomorrow, Thanks :) |
|
Will you merge? |
|
@forsd Yes, Actually I am unable to check it out, will surely check it asap. |
|
@forsd Is this PR contains 'Show typing issue' ? |
|
No. This contains only youtube video embedding. The second contains typing issue. |
|
@forsd, This also contains the Typing commits check out the commits.. |
|
@forsd I have checked, Youtube embedding is working great but typing isnt working.. so either remove the lastest(typing) commit so i will merge so fixed typing as well |
public/assests/js/message.js
Outdated
| var messageText = $("<div></div>").addClass("message-text"); | ||
|
|
||
| // Embed YouTube video if link presents in message. | ||
| var youtube_link = data[i].message.indexOf('https://www.youtube.com'); |
There was a problem hiding this comment.
@forsd You need to check it for youtube short url like https://youtu.be/* and one more thing, pls put this link in <a> tag so user can opn this link directly in the new tab also
|
Typing removed from this PR. |
|
@forsd I have requested for some changes. |
|
@forsd Are you fixing this ? |
|
Sure. |
public/assests/js/message.js
Outdated
| @@ -203,13 +203,21 @@ function updateConversation(data) { | |||
| var messageText = $("<div></div>").addClass("message-text"); | |||
|
|
|||
| // Embed YouTube video if link presents in message. | |||
| var result = anchorme(data[i].message.replace(/<(?:.|\n)*?>/gm, ''), { attributes:[ { name:"target", value:"_blank" } ] }); | |||
| var youtube_link = data[i].message.indexOf('https://www.youtube.com'); | |||
| if(youtube_link !== -1) { | |||
There was a problem hiding this comment.
Rather repeating the same code again and again, it would be better to make a new function and cal that function on getting link similar to http://youtube.com or http://youtu.be/ else will send message. What do you say ??
|
@forsd Are you going to fix this ? |
|
@ankitjain28may Sure I will |
|
@forsd Are you still working ? |
No description provided.