Improve the randomness of the tokens, slightly #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
approved these changes
Nov 26, 2024
mcg1969
force-pushed
the
rand-improve
branch
from
ee4318d
to
89062b4
Compare
mcg1969
force-pushed
the
rand-improve
branch
from
89062b4
to
22223fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tokens are currently 22 characters long. The reason for this is because a base64-encoding of 128 random bits, or 16 random bytes, consumes 22 characters. But in fact, going the other way, 22 characters can actually hold 16.5 bytes, or 132 random bits. So we're not really making the absolute most of the space we're consuming.
Does this matter? Nah. 16 bytes of randomness is plenty. There are really no security implications. But I think this has a mild benefit of helping reassure our users that we're trying to do our level best to ensure randomness, and therefore anonymity.