Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass through inputs for SerializableProgram simulation #1033

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

rmshaffer
Copy link
Contributor

Issue #, if available:

Description of changes:
Properly pass through inputs when simulating a SerializableProgram instance.

Testing done:
tox passes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ddb3d2) to head (e577a86).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         9032      9033    +1     
  Branches      2029      2029           
=========================================
+ Hits          9032      9033    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer marked this pull request as ready for review September 23, 2024 18:03
@rmshaffer rmshaffer requested a review from a team as a code owner September 23, 2024 18:03
@rmshaffer rmshaffer merged commit fd597d6 into main Sep 23, 2024
26 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/serializable-program-inputs branch September 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants