Micro-optimization to AmazingPrint::ActiveRecord#cast #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept seeing Module#ancestors show up in some profiling involving SemanticLogger.
Changing to
x.is_a?(ActiveRecord::Relation)
andy <= ActiveRecord::Base
should be equivalent, but makesAmazingPrint::Inspector#awesome
7% faster:I might be missing something though - any idea why
ancestors
was used in the first place?