Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

Issue 42 #46

Merged
merged 7 commits into from
Aug 27, 2018
Merged

Issue 42 #46

merged 7 commits into from
Aug 27, 2018

Conversation

balmas
Copy link
Member

@balmas balmas commented Aug 24, 2018 •
edited
Loading

Fix for #42

See related PRs in morph-client and components
Can be tested with https://github.com/alpheios-project/webextension/tree/issues-whitakers-engine

@balmas balmas requested review from irina060981 and kirlat August 24, 2018 15:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 83.192% when pulling 7edc534 on issue-42 into cc3e752 on master.

This was referenced Aug 24, 2018
Merged
Merged
irina060981
irina060981 approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member

@irina060981 irina060981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed it with the help of embedded-lib - everything works fine :)

kirlat
kirlat approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@kirlat kirlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@balmas balmas merged commit 94867f7 into master Aug 27, 2018
@balmas balmas deleted the issue-42 branch August 27, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirlat kirlat kirlat approved these changes

@irina060981 irina060981 irina060981 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balmas @coveralls @irina060981 @kirlat