feat(mask): unset bit, count set bits, index of the first set bit #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
requested review from
DaniPopes,
gakonst and
rkrasiuk
as code owners
rkrasiuk
approved these changes
Oct 15, 2024
shekhirin
changed the title
rkrasiuk
reviewed
Oct 15, 2024
src/mask.rs
Outdated
Comment on lines
81
to
83
| pub const fn first_set_bit_index(self) -> u8 { | ||
| self.0.trailing_zeros() as u8 | ||
| } |
There was a problem hiding this comment.
should this return Option? no bits might be set
rkrasiuk
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for paradigmxyz/reth#11743