Merge pull request #17 from LeKer29/feat/TP-6775

[FEAT] add field number to algoan accounts
algoan · Sep 21, 2021 · c7d5436 · c7d5436
2 parents f88291c + d1b5ea6
commit c7d5436
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 0 deletions.
diff --git a/src/algoan/dto/analysis.inputs.ts b/src/algoan/dto/analysis.inputs.ts
@@ -29,6 +29,8 @@ export interface Account {
   details?: AccountDetails;
   aggregator?: AccountAggregator;
   transactions?: AccountTransaction[];
+  // eslint-disable-next-line
+  number?: string;
 }
 
 /**

diff --git a/src/hooks/mappers/analysis.mapper.spec.ts b/src/hooks/mappers/analysis.mapper.spec.ts
@@ -214,6 +214,8 @@ describe('AnalysisMapper', () => {
         },
         transactions: tinkTransactionsMock.map(mapToAlgoanTransaction),
         ...mapToIbanAndBic(tinkAccountObjectMock.identifiers),
+        // eslint-disable-next-line
+        number: '1234-123456789',
       });
 
       // Same number of transaction
@@ -256,6 +258,8 @@ describe('AnalysisMapper', () => {
         },
         transactions: tinkTransactionsMock.map(mapToAlgoanTransaction),
         ...mapToIbanAndBic(tinkAccountObjectMock.identifiers),
+        // eslint-disable-next-line
+        number: '1234-123456789',
       });
     });
 
@@ -384,6 +388,8 @@ describe('AnalysisMapper', () => {
             ],
             type: 'CHECKING',
             usage: 'PERSONAL',
+            // eslint-disable-next-line
+            number: '1234-123456789',
           },
           {
             aggregator: {
@@ -426,6 +432,8 @@ describe('AnalysisMapper', () => {
             ],
             type: 'CHECKING',
             usage: 'PERSONAL',
+            // eslint-disable-next-line
+            number: '1234-123456789',
           },
         ],
       });

diff --git a/src/hooks/mappers/analysis.mapper.ts b/src/hooks/mappers/analysis.mapper.ts
@@ -80,6 +80,8 @@ export function mapToAlgoanAccount(
     },
     transactions: tinkTransactions.map(mapToAlgoanTransaction),
     ...mapToIbanAndBic(tinkAccount.identifiers),
+    // eslint-disable-next-line
+    number: tinkAccount.accountNumber,
   };
 }
 

diff --git a/src/tink/dto/account.objects.mock.ts b/src/tink/dto/account.objects.mock.ts
@@ -28,6 +28,7 @@ export const tinkAccountObjectMock: TinkAccountObject = {
   holderName: 'Thomas Alan Waits',
   name: 'My account',
   type: TinkAccountType.CHECKING,
+  accountNumber: '1234-123456789',
 };
 
 /**

diff --git a/src/tink/dto/account.objects.ts b/src/tink/dto/account.objects.ts
@@ -27,6 +27,7 @@ export interface TinkAccountObject<NullOrUndefined = undefined> {
   name: string;
   type: TinkAccountType;
   iban?: string; // Don't know yet if it is returned each time, not in the documentation.
+  accountNumber?: string;
 }
 
 /**