mp4a: Support DecoderSpecificDescriptor profiles > 30 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptions may require different amount of bytes to serialize depending on content of fields. In preparation of supporing reading and writing DecoderSpecificDescriptor::profiles (audio object type) values larger than 30.
Adds support for reading and writing AAC audio specific info when profile (object type) is larger than 30.
petzeb
force-pushed
the
support_writing_extended_aots
branch
from
e1ec2f3
to
0a3973b
Compare
petzeb
commented
Oct 17, 2023
| write_desc(writer, Self::desc_tag(), size)?; | ||
|
|
||
| writer.write_u8((self.profile << 3) + (self.freq_index >> 1))?; | ||
| writer.write_u8((self.freq_index << 7) + (self.chan_conf << 3))?; | ||
| if self.profile < 31 { |
There was a problem hiding this comment.
A potential option could be to use some crate like:
https://docs.rs/bitstream-io/1.7.0/bitstream_io/
for this bit packing (and unpacking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading and writing AAC audio specific info when profile (object type) is larger than 30.