-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: desktop wallet on Windows while 'About' window is still open leads to a white screen #977
base: next
Are you sure you want to change the base?
Conversation
|
9b974a7
to
1f63da4
Compare
1f63da4
to
4378e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @forbesus, thanks a lot for the contribution! I'll run the code when I find the time. Much obliged!
? [{ role: 'about' }, { type: 'separator' }] | ||
? [ | ||
{ | ||
label: `About ${app.getName()}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the role: 'about'
that we had before is responsible for translating the word "About" based on the user's locale...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all menu items are not translated based on user's locale @nop33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a more appropriate solution would be to find a way to close all windows when the main wallet window is closed. I would prefer to keep the default behavior of the electron about
role. @mvaivre what's your feedback?
@forbesus, as you can see the dev team has tagged it with a 5 ALPH reward, making you eligible to receive this amount. I couldn't find a way to contact you in your github profile, could you contact [email protected] so I can send you the info/process to receive the reward/bounty ? |
ref #964