Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: desktop wallet on Windows while 'About' window is still open leads to a white screen #977

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

forbesus
Copy link

ref #964

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 4378e45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@forbesus forbesus force-pushed the fix/windows-about-button branch from 9b974a7 to 1f63da4 Compare November 19, 2024 14:39
@forbesus forbesus force-pushed the fix/windows-about-button branch from 1f63da4 to 4378e45 Compare November 19, 2024 14:41
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @forbesus, thanks a lot for the contribution! I'll run the code when I find the time. Much obliged!

? [{ role: 'about' }, { type: 'separator' }]
? [
{
label: `About ${app.getName()}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the role: 'about' that we had before is responsible for translating the word "About" based on the user's locale...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all menu items are not translated based on user's locale @nop33

@nop33 nop33 added the 🖥 DW Desktop wallet label Nov 19, 2024
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more appropriate solution would be to find a way to close all windows when the main wallet window is closed. I would prefer to keep the default behavior of the electron about role. @mvaivre what's your feedback?

@nop33 nop33 added the ALPH-5 label Nov 25, 2024
@MaudSimon
Copy link
Member

@forbesus, as you can see the dev team has tagged it with a 5 ALPH reward, making you eligible to receive this amount. I couldn't find a way to contact you in your github profile, could you contact [email protected] so I can send you the info/process to receive the reward/bounty ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALPH-5 🖥 DW Desktop wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants