Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ivy APIs for embedded Maven during zpmw install #1334

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Replace Ivy APIs for embedded Maven during zpmw install #1334

wants to merge 15 commits into from

Conversation

bmaidics
Copy link
Contributor

Fixes #1173

jfallows
jfallows requested changes Nov 27, 2024
View reviewed changes
manager/NOTICE Outdated Show resolved Hide resolved
manager/NOTICE Outdated Show resolved Hide resolved
manager/pom.xml Outdated Show resolved Hide resolved
manager/pom.xml Outdated Show resolved Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java Outdated Show resolved Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java Outdated Show resolved Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmRepository.java Outdated Show resolved Hide resolved
...ger/src/main/java/io/aklivity/zilla/manager/internal/commands/install/cache/ZpmArtifact.java Outdated Show resolved Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/cache/ZpmCache.java Outdated Show resolved Hide resolved
jfallows
jfallows reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the zpm encrypt command is now no longer relevant after these changes and should be removed, agree?

cloud/docker-image/src/main/docker/incubator/debug_krishna.pcap Outdated Show resolved Hide resolved
cloud/docker-image/src/main/docker/incubator/debug.pcap Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Ivy APIs for embedded Maven during zpmw install
2 participants
@bmaidics @jfallows