Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pooch to environment.yml file #29

Closed
wants to merge 1 commit into from
Closed

Conversation

mtb-za
Copy link
Contributor

@mtb-za mtb-za commented Feb 28, 2022

At least one notebook in the current master branch uses pooch, so we need to make sure that it is installed with everything else. We expect that more will use it, moving forwards.

At least one notebook in the current `master` branch uses `pooch`, so we need to make sure that it is installed with everything else. We expect that more will use it, moving forwards.
@kwinkunks
Copy link
Member

If we end up using pooch a lot, then it belongs in environment.yaml, but otherwise the thing to do is to place it in the YAML control file for any course that uses the notebook(s) that require it. It's only libraries that all (or at least most) of the classes need that go in environment.yaml.

In other words, it's not the case that building an env with environment.yaml will enable a person to run all the notebooks in prod. Right now, there's no way to do that because there's no way to survey the notebooks either en masse or (say) from a list in a course YAML file. That would be a cool feature and is related to Issue #3 in kosu.

@kwinkunks kwinkunks closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants