Merge pull request #24 from mihaerzen/master

Fix "autoInvalidate"
aghadiry · Sep 1, 2021 · df793f7 · df793f7
2 parents 581b8f8 + 75c6348
commit df793f7
Showing 1 changed file with 21 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -39,11 +39,8 @@ class CloudfrontInvalidate {
 
     this.hooks = {
       'cloudfrontInvalidate:invalidate': this.invalidate.bind(this),
+      'after:deploy:deploy': this.invalidate.bind(this),
     };
-
-    if (serverless.service.custom.cloudfrontInvalidate.autoInvalidate !== false) {
-      this.hooks['after:deploy:deploy'] = this.invalidate.bind(this)
-    }
   }
 
   setProxy(proxyURL) {
@@ -100,7 +97,9 @@ class CloudfrontInvalidate {
       return;
     }
 
-    this.serverless.service.custom.cloudfrontInvalidate.forEach(element => {
+    const invalidationPromises = this.serverless.service.custom.cloudfrontInvalidate.map(element => {
+      const autoInvalidate = element.autoInvalidate !== false;
+
       let cloudfrontInvalidate = element;
       let reference = randomstring.generate(16);
       let distributionId = cloudfrontInvalidate.distributionId;
@@ -112,6 +111,12 @@ class CloudfrontInvalidate {
 
       if (distributionId) {
         cli.consoleLog(`DistributionId: ${chalk.yellow(distributionId)}`);
+
+        if (autoInvalidate === false) {
+          cli.consoleLog(`Skipping invalidation for the distributionId "${distributionId}" as autoInvalidate is set to false.`);
+          return;
+        }
+
         return this.createInvalidation(distributionId, reference, cloudfrontInvalidate);
       }
 
@@ -136,12 +141,20 @@ class CloudfrontInvalidate {
             });
           }
         })
-        .then(() => this.createInvalidation(distributionId, reference, cloudfrontInvalidate))
-        .catch(error => {
+        .then(() => {
+          if (autoInvalidate === false) {
+            cli.consoleLog(`Skipping invalidation for the distributionId "${distributionId}" as autoInvalidate is set to false.`);
+            return;
+          }
+
+          return this.createInvalidation(distributionId, reference, cloudfrontInvalidate);
+        })
+        .catch(() => {
           cli.consoleLog('Failed to get DistributionId from stack output. Please check your serverless template.');
-          return;
         });
     });
+
+    return Promise.all(invalidationPromises);
   }
 }