Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naydav
Copy link

@naydav naydav commented Oct 8, 2024

Original PR (from fork) #512

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

Related Issues

Thanks for contributing!

@naydav naydav changed the title Sites 25573 feat: SITES-25573 Enable/Disable domains for CWV audit via API/slack command Oct 8, 2024
@naydav naydav marked this pull request as ready for review October 8, 2024 16:02
Copy link

github-actions bot commented Oct 8, 2024

This PR will trigger a minor release when merged.

Copy link
Member

@nitinja nitinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants