fix: ACNA-1026 - aio app test is failing on EBADF bad file descriptor (Windows only)

[shazron]

Fixes #372
Note that because of this fix, killing of aio-run-detached processes will not work on Windows, until this node bug is fixed.

How Has This Been Tested?

npm test

• test on Windows
• test on Linux
• test on macOS

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #415 (5b2f883) into master (e7b1749) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1693      1698    +5     
  Branches       284       286    +2     
=========================================
+ Hits          1693      1698    +5     

Impacted Files	Coverage Δ
src/lib/app-helper.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b1749...5b2f883. Read the comment docs.

[purplecabbage]

Does it make sense to just add the child.on("message" regardless of isWindows, and just let it never fire?

[shazron]

Does it make sense to just add the child.on("message" regardless of isWindows, and just let it never fire?

actually it is conditional, I pushed an update probably while you were reviewing: 5b2f883