Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): post header margin on mobile #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

David-Guillot
Copy link

What does this PR change? What problem does it solve?

On mobile, the spacing between the page header and the post title feels too big. I guessed this is caused by the use of hard-coded 24px on margin-top instead of the --gap variable, whose value is 24px by default but get down to 14px on smaller screens and mobile.

See the difference on the theme Install page:

Before After
Capture d’écran du 2024-07-11 14-30-58 Capture d’écran du 2024-07-11 14-31-15

Was the change discussed in an issue or in the Discussions before?

Clearly not 😬

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

.post-header was not using the `--gap` variable, so the overriding of this variable on mobile was not applied.
Copy link

sonarcloud bot commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant