fix: default to localized date formatting #1552
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
On a multilingual blog with translated posts, a non-English post displays an English-formatted non-English date like
juillet 8, 2024
instead of8 juillet 2024
as it should be for French.This PR changes the
post_meta
partial template to leverage Hugo's time.Format function's preset formats. I have chosen:date_long
since it's the one that was hard-coded here before.Was the change discussed in an issue or in the Discussions before?
Nope, I just discovered this behavior and considered it a bug, so I just took the liberty of opening a PR. This PR fixes the same problem as #1111 though, but without any additional code, just using native Hugo features.
And actually I just created #1611 for you to have a clear view on the issue. This PR fixes the issue on both places because as you know the
post_meta.html
template is included both inlist.html
and insingle.html
.PR Checklist