Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckoutV2: Add Amount Allocations object #5186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justingrobles
Copy link

@justingrobles justingrobles commented Jul 18, 2024

Description

Add Amount Allocations object for Sub-Entity payments as Marketplace object is deprecated.

Referrence

image
LOCAL: rake test:local TEST=test/unit/gateways/checkout_v2_test.rb
Finished in 0.020203 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
68 tests, 431 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------
3365.84 tests/s, 21333.47 assertions/s
REMOTE: rake test:remote TEST=test/remote/gateways/remote_checkout_v2_test.rb
- Update fixtures (Checkout Keys), three (3) processing_channel_id and entity_id.

Finished in 169.233266 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
113 tests, 267 assertions, 15 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.7257% passed
-----------------------------------------------------------------------------------------------------------------------------------
0.67 tests/s, 1.58 assertions/s

Test Failed (Existing based on Test against Master):
- test_expired_card_returns_error_code
- test_failed_purchase
- test_invalid_shipping_address
- test_money_transfer_payout_handles_blank_destination_address
- test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
- test_successful_authorize_includes_avs_result
- test_successful_credit
- test_successful_money_transfer_payout_via_credit_corporate_account_holder_type
- test_successful_money_transfer_payout_via_credit_individual_account_holder_type
- test_successful_purchase_includes_avs_result
- test_successful_purchase_with_ip
- test_successful_purchase_with_minimal_options
- test_successful_purchase_with_processing_data
- test_successful_purchase_with_shipping_address
- test_successful_purchase_without_phone_number
Test on Master
LOCAL: rake test:local TEST=test/unit/gateways/checkout_v2_test.rb
Finished in 0.017151 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
67 tests, 420 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------
3906.48 tests/s, 24488.37 assertions/s
REMOTE: rake test:remote TEST=test/remote/gateways/remote_checkout_v2_test.rb
- Update fixtures (Checkout Keys) and three (3) processing_channel_id.

===================================================================================================================================
Finished in 172.939637 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
113 tests, 267 assertions, 15 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.7257% passed
-----------------------------------------------------------------------------------------------------------------------------------
0.65 tests/s, 1.54 assertions/s

Failed Test
- test_expired_card_returns_error_code
- test_failed_purchase
- test_invalid_shipping_address
- test_money_transfer_payout_handles_blank_destination_address
- test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
- test_successful_authorize_includes_avs_result
- test_successful_credit
- test_successful_money_transfer_payout_via_credit_corporate_account_holder_type
- test_successful_money_transfer_payout_via_credit_individual_account_holder_type
- test_successful_purchase_includes_avs_result
- test_successful_purchase_with_ip
- test_successful_purchase_with_minimal_options
- test_successful_purchase_with_processing_data
- test_successful_purchase_with_shipping_address
- test_successful_purchase_without_phone_number

Add Amount Allocations object for Sub-Entity payments as Marketplace object is deprecated.

LOCAL: rake test:local TEST=test/unit/gateways/checkout_v2_test.rb
Finished in 0.020203 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
68 tests, 431 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------
3365.84 tests/s, 21333.47 assertions/s

REMOTE: rake test:remote TEST=test/remote/gateways/remote_checkout_v2_test.rb
- Update fixtures (Checkout Keys), three (3) processing_channel_id and entity_id.

Finished in 169.233266 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
113 tests, 267 assertions, 15 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.7257% passed
-----------------------------------------------------------------------------------------------------------------------------------
0.67 tests/s, 1.58 assertions/s

Test Failed:
- test_expired_card_returns_error_code
- test_failed_purchase
- test_invalid_shipping_address
- test_money_transfer_payout_handles_blank_destination_address
- test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
- test_successful_authorize_includes_avs_result
- test_successful_credit
- test_successful_money_transfer_payout_via_credit_corporate_account_holder_type
- test_successful_money_transfer_payout_via_credit_individual_account_holder_type
- test_successful_purchase_includes_avs_result
- test_successful_purchase_with_ip
- test_successful_purchase_with_minimal_options
- test_successful_purchase_with_processing_data
- test_successful_purchase_with_shipping_address
- test_successful_purchase_without_phone_number
@justingrobles justingrobles force-pushed the checkout_v2/add_amount_allocation branch from 8dc512f to ba43711 Compare September 4, 2024 03:13
@justingrobles justingrobles changed the title Checkout_v2: Add Amount Allocations object CheckoutV2: Add Amount Allocations object Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant