Handling the unneeded migration filecreation using method_added capture approach #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re approach Signed-off-by: Naveen Honest Raj K <[email protected]>
boie0025
approved these changes
Jun 20, 2021
grzegorz-jakubiak
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #137 (Migration related to comments getting created during
rails g active_admin:install)Considering the Rails::Generators::NamedBase is one of the nearest ancestor to ActiveAdmin::Generators::InstallGenerator, we can open the class and an empty create_migration to the class(which will overridden by other subclasses). We can specifically focus on the ActiveAdmin::Generators::InstallGenerator class and apply
remove_methodduring themethod_addedcall and thereby pushing ActiveAdmin::Generators::InstallGenerator to use our emptycreate_migrationsmethod.Verified locally and the specs are passing in local as well.
@boie0025 @grzegorz-jakubiak Please let me know if this changes doesn't a right fit for the facing issue.
Signed-off-by: Naveen Honest Raj K [email protected]