Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile - non-existent buildx version #3387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asaf400
Copy link

@asaf400 asaf400 commented Jul 14, 2024

The download URL for the specified buildx version in the current Dockerfile (v0.13.2) was either removed at some point, or never existed..

The full 'default' URL is therefore broken: https://github.com/docker/buildx/releases/download/v0.13.2/buildx-v0.13.2.linux-amd64

while newer versions work:
https://github.com/docker/buildx/releases/download/v0.16.0/buildx-v0.16.0.linux-amd64

The change is UNTESTED, but I've looked through the release notes, and there only noticeable changes, but no breaking changes..

evidence of errors:

 > [build 6/6] RUN export RUNNER_ARCH=amd64     && if [ "$RUNNER_ARCH" = "amd64" ]; then export DOCKER_ARCH=x86_64 ; fi     && if [ "$RUNNER_ARCH" = "arm64" ]; then export DOCKER_ARCH=aarch64 ; fi     && curl -fLo docker.tgz https://download.docker.com/linux/static/stable/${DOCKER_ARCH}/docker-25.0.5.tgz     && tar zxvf docker.tgz     && rm -rf docker.tgz     && mkdir -p /usr/local/lib/docker/cli-plugins     && curl -fLo /usr/local/lib/docker/cli-plugins/docker-buildx         "https://github.com/docker/buildx/releases/download/v0.13.2/buildx-v0.13.2.linux-amd64"     && chmod +x /usr/local/lib/docker/cli-plugins/docker-buildx:
0.433   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
0.433                                  Dload  Upload   Total   Spent    Left  Speed
100 68.2M  100 68.2M    0     0  18.0M      0  0:00:03  0:00:03 --:--:-- 18.0M
16.83 curl: (22) The requested URL returned error: 404

The download URL for the specified buildx version - v0.13.2 was removed at some point, or never existed..

The full 'default' URL is therefore broken: https://github.com/docker/buildx/releases/download/v0.13.2/buildx-v0.13.2.linux-amd64

while newer versions work:
https://github.com/docker/buildx/releases/download/v0.16.0/buildx-v0.16.0.linux-amd64

The change is UNTESTED, but I've looked through the release notes, and there only noticeable changes, but no breaking changes..
@asaf400 asaf400 requested a review from a team as a code owner July 14, 2024 10:05
@joh-klein
Copy link

The current main uses 0.16.2 already – so you could maybe close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants