Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: mfa #1064

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

feat!: mfa #1064

wants to merge 21 commits into from

Conversation

pradel
Copy link
Member

@pradel pradel commented Nov 16, 2020

No description provided.

@pradel pradel changed the title Feature/moduar mfa feat!: mfa Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1064 (106bebf) into master (fefb328) will decrease coverage by 2.15%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   95.07%   92.91%   -2.16%     
==========================================
  Files          81       93      +12     
  Lines        1807     2203     +396     
  Branches      391      480      +89     
==========================================
+ Hits         1718     2047     +329     
- Misses         87      153      +66     
- Partials        2        3       +1     
Impacted Files Coverage Δ
...raphql-api/src/modules/accounts/schema/mutation.ts 100.00% <ø> (ø)
packages/graphql-api/src/modules/core/schema.ts 100.00% <ø> (ø)
...raphql-api/src/modules/accounts/resolvers/index.ts 14.28% <14.28%> (ø)
packages/mfa/src/accounts-mfa.ts 44.21% <44.21%> (ø)
...ages/graphql-api/src/modules/accounts-mfa/index.ts 70.58% <70.58%> (ø)
packages/graphql-api/src/modules/accounts/index.ts 75.00% <75.00%> (-1.00%) ⬇️
packages/mfa/src/errors.ts 85.71% <85.71%> (ø)
packages/client-password/src/client-password.ts 100.00% <100.00%> (ø)
packages/client/src/accounts-client.ts 100.00% <100.00%> (+1.11%) ⬆️
packages/database-manager/src/database-manager.ts 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefb328...106bebf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants