Use BufReader
for PyFileLikeObject
with 1MB buffer
#69
+63
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps
PyFileLikeObject
inBufReader
with a 1MB buffer for BAM, BCF,VCF, and BigWig readers. Avoids changing the behavior of
new
toprevent baking in assumptions about buffering needs or sizes, preserving
flexibility for unbuffered use cases.
Follow-up to #68
We want to avoid setting up the buffer inside
new
because it bakes in an opinion about buffering, which might conflict with cases where readers are already buffered, and it removes flexibility for users to configure buffer sizes or avoid buffering entirely if our choices are undesirable for their use case.