smhasher: Set UNALIGNED_SAFE for 64-bit intel too. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better for perf, and also happens to suppress a new clang warning:
PMurHash.c(209,12): error: cast to smaller integer type 'long' from
'const unsigned char *' is a Microsoft extension [-Werror,-Wmicrosoft-cast]
int i = -(long)ptr & 3;
^~~~~~~~~
64-bit Windows is the only platform I know where long is smaller than
a pointer, and this code is in the !UNALIGNED_SAFE branch. So this patch
addresses the warning.
(Alternatively, we could insert a cast to (uintptr_t) before casting to
long, but the code seems to try to work before C99.)
https://crbug.com/1054220
|
I forgot about amd64; we'll have to patch the warning in the unaligned branch for that. But this seems like a good change regardless. |
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Mar 15, 2020
The code causes a new compile warning, and it's unused. So stop building it. (See also aappleby/smhasher#81 failing to get traction.) Bug: 1054220,1058381 Change-Id: I68758e94cd2728df70e78c60e9be0bb4006a847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103719 Auto-Submit: Nico Weber <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#750421}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better for perf, and also happens to suppress a new clang warning:
PMurHash.c(209,12): error: cast to smaller integer type 'long' from
'const unsigned char *' is a Microsoft extension [-Werror,-Wmicrosoft-cast]
int i = -(long)ptr & 3;
^~~~~~~~~
64-bit Windows is the only platform I know where long is smaller than
a pointer, and this code is in the !UNALIGNED_SAFE branch. So this patch
addresses the warning.
(Alternatively, we could insert a cast to (uintptr_t) before casting to
long, but the code seems to try to work before C99.)
https://crbug.com/1054220