Feature/constistent api #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
JesusMcCloud
had a problem deploying
to
github-pages
GitHub Actions
Failure
JesusMcCloud
had a problem deploying
to
github-pages
GitHub Actions
Failure
JesusMcCloud
had a problem deploying
to
github-pages
GitHub Actions
Failure
iaik-jheher
requested changes
Sep 19, 2024
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Outdated
Show resolved
Hide resolved
JesusMcCloud
had a problem deploying
to
github-pages
GitHub Actions
Failure
iaik-jheher
reviewed
Sep 20, 2024
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/CryptoPublicKey.kt
Outdated
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Outdated
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Outdated
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Show resolved
Hide resolved
|
i did not directly commti your suggestions but added them manually into my commit |
that's preferable anyway 👍 |
iaik-jheher
reviewed
Sep 20, 2024
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Outdated
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Show resolved
Hide resolved
...ensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Decoding.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakob Heher <[email protected]>
Co-authored-by: Jakob Heher <[email protected]>
Co-authored-by: Jakob Heher <[email protected]>
iaik-jheher
approved these changes
Sep 20, 2024
JesusMcCloud
added a commit
that referenced
this pull request
Sep 20, 2024
* Revamp `Asn1Element.parse()`, introducing new variants. This yields:
* `Asn1Element.parse()` with the same semantics as before
* `Asn1Element.parse()` alternative introduced, which takes a `ByteIterator` instead of a `ByteArray`
* `Asn1Element.parseAll()` introduced, which consumes all bytes and returns a list of all ASN.1 elements (if parsing works)
* Variant 1 takes a `ByteIterator`
* Variant 2 takes a `ByteArray`
* `Asn1Element.parseFirst()` introduced, which tries to only parse a single ASN.1 element from the input and leaves the rest untouched.
* Variant 1 takes a `ByteIterator` and returns the element; the `ByteIterator` is advanced accordingly
* Variant 2 takes a `ByteArray` and returns a `Pair` of `(element, remainingBytes)`
* More consistent low-level encoding and decoding function names:
* `encodeToAsn1Primitive` to produce an `Asn1Primitive` that can directly be DER-encoded
* `encodeToAsn1ContentBytes` to produce the content bytes of a TLV primitive (the _V_ in TLV)
* `decodeToXXX` to be invoked on an `Asn1Primitive` to decode a DER-encoded primitive into the target type
* `decodeFromAsn1ContentBytes` to be invoked on the companion of the target type to decode the content bytes of a TLV primitive (the _V_ in TLV)
* Update conventions -> Coroutines 1.0.9
---------
Co-authored-by: Jakob Heher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent encoding and decoding api, including parsing only the first element from a bytearray