Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli #84

Merged
merged 36 commits into from
Sep 26, 2023
Merged

Update cli #84

merged 36 commits into from
Sep 26, 2023

Conversation

max-zengo
Copy link
Collaborator

@max-zengo max-zengo commented Sep 18, 2023 •
edited by leontiadZen
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🔁 CI/CD
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Demo CLI wallet for Bitcoin and Ethereum

Solves

#74

@max-zengo
add options in clap Derive mode
fdb72c7
@max-zengo
temp cargo changes
4313a5e
@max-zengo
temp wallet mod changes
5ea7db0
@max-zengo
only secp256k1 0.21.3 and 0.20.3 duplication remains
12223d5
@max-zengo
code compiles
6cb7323
@max-zengo
begin integration debugging
436e9bd
@max-zengo
* move to Electrumx trait
ae32e76 
* default values to cli
@max-zengo
private_share.master_key.chain_code changes from ChainCode2 struct to…
ae7590b 
… BigInt
@max-zengo
intermediate testing
e7ad580
@max-zengo
* replace SighashComponents with SigHashCache
62fc88a 
* update to electrumx_client [email protected]
@max-zengo
cargo fmt --all
843fddd
@max-zengo
minor changes
5a5fa40
@max-zengo
minor cli commands change
62bf0d3
@max-zengo
export elliptic::curves::traits::ECPoint in client lib
2cd871a
@max-zengo
export elliptic::curves::traits::* in client lib
5a7338f
@max-zengo
import ethereum cli external code into demo-wallet package.
20edea6 
Move Bitcoin cli code to demo-wallet package.
@max-zengo
reorder code into several files
408a4f4
@max-zengo
clean clap from Cargo.toml files
3df542d
@max-zengo
delete cli.yml
586e52e
@max-zengo
clean Cargo.toml
e9904dc
@max-zengo
pass settings to bitcoin_commands function
aecb72a
@max-zengo
return Cargo.lock for integration tests
f577daf
@max-zengo
return Cargo.lock for integration tests
bd60c0c
@max-zengo
Merge branch 'master' into update-cli
ca9bc5f
@max-zengo
return Cargo.lock for integration tests
17b7c01
@max-zengo
cargo fmt --all
a561d9b
@max-zengo max-zengo added enhancement New feature or request dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Sep 18, 2023
@max-zengo max-zengo self-assigned this Sep 18, 2023
leontiadZen
leontiadZen approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@leontiadZen leontiadZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leontiadZen leontiadZen marked this pull request as ready for review September 26, 2023 07:15
@max-zengo max-zengo merged commit 1b785a9 into master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leontiadZen leontiadZen leontiadZen approved these changes

Assignees

@max-zengo max-zengo

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-zengo @leontiadZen