-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): Fixes bugs in the lightwalletd integration tests #9052
Conversation
4234291
to
0ecf779
Compare
… code for sending transactions to its own fn
…eturn an error for more detailed error info
98bb7a4
to
07fa64e
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this PR before. It looks good, I just have some questions about parts of it.
FYI I got this error on another PR:
which does seems like something that might be fixed by this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs solving conflicts
I still need to fix the new test failure before this merges ( |
The test is now passing locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a question just to be sure about the fix of the last issue
sending_transactions_using_lightwalletd
test
This pull request has been removed from the queue for the following reason: Pull request #9052 has been dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
(It was dequeued because I noticed that issue I commented just after I approved it) |
Co-authored-by: Conrado Gouvea <[email protected]>
Motivation
This PR fixes a bug in the
sending_transactions_using_lightwalletd
test where transactions from multiple future blocks are being sent to the mempool without committing prior blocks to the chain.It also fixes a bug in the
lightwalletd_wallet_grpc_tests
where the test expects the ZF funding stream address balance to always be greater than zero.Solution
sending_transactions_using_lightwalletd
test, andlightwalletd_wallet_grpc_tests
test.Tests
The test should pass in CI.
PR Author's Checklist
PR Reviewer's Checklist