suggestion to don't clone self in get_block
#9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
reviewed
Nov 22, 2024
Comment on lines
+757
to
+761
| let get_block_header_future = if matches!(verbosity, 1 | 2) { | ||
| Some(self.get_block_header(original_hash_or_height.clone(), Some(true))) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
Optional/Nitpick/Subjective: This may actually be a little less readable, but it's tempting to use then() here.
Suggested change
| let get_block_header_future = if matches!(verbosity, 1 | 2) { | |
| Some(self.get_block_header(original_hash_or_height.clone(), Some(true))) | |
| } else { | |
| None | |
| }; | |
| let get_block_header_future = matches!(verbosity, 1 | 2) | |
| .then(|| self.get_block_header(original_hash_or_height.clone(), Some(true))); |
|
@conradoplg There's very little in |
|
Thanks! I'm not sure if this will solve the issues I'm getting implementing #9024 but I'll give it a shot there, inspired on this approoach. |
mergify bot
added a commit
that referenced
this pull request
Dec 2, 2024
* rpc: align getblock with zcashd behaviour * Removes handling for verbosity = 3 in getblock method, adds finalorchardroot field, removes unnecessary state request. (#9008) * align final(sapling|orchard)root with zcashd behaviour * fix test * Apply suggestions from code review Co-authored-by: Alfredo Garcia <[email protected]> * restore getblock docs; remove unneeded TODOs * Update zebra-rpc/src/methods.rs Co-authored-by: Arya <[email protected]> * get rif of cloning self (#9044) --------- Co-authored-by: Arya <[email protected]> Co-authored-by: Alfredo Garcia <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #9006 we are cloning self in the
get_blockimplementation which could bring some problems in some tests.Solution
This is an alternative to do that that @conradoplg might find useful, feel free to discard.