Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getblock: return transactions details with verbosity=2 #9024

Open
conradoplg opened this issue Nov 14, 2024 · 0 comments · Fixed by #9084 · May be fixed by #9083
Open

getblock: return transactions details with verbosity=2 #9024

conradoplg opened this issue Nov 14, 2024 · 0 comments · Fixed by #9084 · May be fixed by #9083
Labels
C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage

Comments

@conradoplg
Copy link
Collaborator

Motivation

For zcashd compatibility. In verbose=2 mode, the transactions details should be returned instead of transaction hashes.

Specifications

https://github.com/zcash/zcash/blob/99ad6fdc3a549ab510422820eea5e5ce9f60a5fd/src/rpc/blockchain.cpp#L797-L799

Complex Code or Requirements

Can probably be done by calling getrawtransaction to reuse its logic.

Testing

No response

Related Work

No response
@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 14, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Nov 14, 2024
@conradoplg conradoplg changed the title getblock: return transactions details with verbose=2 getblock: return transactions details with verbosity=2 Nov 14, 2024
@conradoplg conradoplg mentioned this issue Nov 19, 2024
Merged
7 tasks
@conradoplg conradoplg mentioned this issue Nov 29, 2024
Merged
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Dec 2, 2024
@conradoplg conradoplg linked a pull request Dec 12, 2024 that will close this issue
Open
7 tasks
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in Zebra Dec 12, 2024
@mpguerra mpguerra linked a pull request Dec 13, 2024 that will close this issue
Suggestion for "add(rpc): getblock: return transaction details with verbosity=2" #9084
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Projects
Zebra
Status: Review/QA
Milestone
No milestone
1 participant
@conradoplg