Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server act as "aggregator" #265

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Make server act as "aggregator" #265

merged 3 commits into from
Aug 14, 2024

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Jul 18, 2024 •
edited
Loading

Closes #251

Basically:

  • This moves the SessionState from the Server to the Coordinator, with some modifications
  • This removes most functions from the state, adding a new send and receive instead

I ended up doing some refactorings to make the implementation simpler. I should've split that into another PR, sorry!

  • I added a ProcessedArgs struct to the Coordinator which is created from a Args, and does all the handling related to reading inputs files or stdin, etc.
  • I added support for specifying multiple messages and randomizers in the arguments, but this is still not used by the rest of the code. Tracked in Server cleanups #266

@conradoplg conradoplg requested a review from natalieesk July 18, 2024 21:40
@conradoplg conradoplg mentioned this pull request Jul 18, 2024
Open
7 tasks
@mpguerra mpguerra linked an issue Jul 19, 2024 that may be closed by this pull request
Make the Coordinator act as "aggregator" instead of the server #251
Closed
natalieesk
natalieesk previously requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little typo, otherwise all great

@mpguerra mpguerra dismissed natalieesk’s stale review August 9, 2024 08:56

Change was made

@conradoplg conradoplg force-pushed the change-architecture branch from ccd6e88 to fe493e2 Compare August 9, 2024 15:17
@conradoplg conradoplg mentioned this pull request Aug 14, 2024
Merged
Base automatically changed from user-registration to main August 14, 2024 21:49
@conradoplg conradoplg force-pushed the change-architecture branch from fe493e2 to 6b8643c Compare August 14, 2024 21:51
@conradoplg conradoplg merged commit 21a1531 into main Aug 14, 2024
5 checks passed
@conradoplg conradoplg deleted the change-architecture branch August 14, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra approved these changes

@natalieesk natalieesk natalieesk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the Coordinator act as "aggregator" instead of the server
3 participants
@conradoplg @mpguerra @natalieesk