Restrict Feliz.CompilerPlugins version required by Feliz 1 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feliz v2 has been in use for a while now, I don't think I want to maintain a separate Feliz v1.x branch just for this 🤔 I would rather if users updated to Feliz v2 if they encountered issues with v1 |
|
@Zaid-Ajaj The problem, is that if they don't use the latest version of Fable 3 then they will only see the problem at the runtime only with some weird errors / behaviours. There was a bug in previous version of Fable 3 which allows to "skip" invalid plugins and keep the compilation going as normal when it should have failed. We are speaking about a one time release, which can avoid them having to debug strange bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Zaid-Ajaj,
Important: This PR is not to be merged into master but should instead go into a feliz1 branch. In theory, I created this branch on the latest commit related to v1.
This branch is related to #544. The goal of this branch is to push a new version of Feliz 1 which restrict Feliz.CompilerPlugin to version 1 only.
I had to use a custom MSBuild task because MSBuild doesn't support version restriction on
ProjectReferenceout of the box.NuGet/Home#5556 (comment)