Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to spi.xfer2 which starts to modify LED information in place #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuan
Copy link
Contributor

@wuan wuan commented Nov 25, 2020

This fixes not working spidev by using the Adafruit SPI implementation if present.

@sleiner
Copy link
Member

sleiner commented Dec 18, 2021

Does spidev not work for you? What errors are you seeing?

@wuan
Copy link
Contributor Author

wuan commented Jan 30, 2022

The current implementation stopped working for me after upgrading to Debian 10. The strip was showing strange patterns instead. One way could be to add Adafruit SPI implementatino as an option.

@wuan
Copy link
Contributor Author

wuan commented Feb 10, 2022

The output is resulting in wrong color values and also the system seems to be frozen from time to time. So for me this is totally unusable with spidev. The problem appeared after upgrading to Debian 10.

@wuan
Copy link
Contributor Author

wuan commented Dec 11, 2022

The underlying problem was, that SpiDev.xfer2(..) was modifying the self.leds content. Now handing over a copy should avoid this problem.

This is related to doceme/py-spidev#61. The problem only appears on Python 3.

@wuan wuan changed the title fix strip by using Adafruit SPI implementation Fix strip which starts to modify LED information in place Dec 25, 2022
@wuan wuan changed the title Fix strip which starts to modify LED information in place Fix call to spi.xfer2 which starts to modify LED information in place Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants