This repository has been archived by the owner on Jun 4, 2020. It is now read-only.
fix #5 - Breaks when a Package title != name #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't open an upstream PR because
fix_tests
hasn't been merged yet...This PR should address bug #5. Please have a look there for context.
In summary: when computing the set of managed packages, we can't just look them up by
title
in the Catalog. Becausetitle
andname
can be different, we need to look into the "resource aliases" table too.I couldn't find a public API to access
@aliases
, hence theinstance_variable_get
hack... :(/cc @hashbrowncipher @solarkennedy @oholiab