Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternate method for quick-tile #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

newhinton
Copy link

This change removes the need for the permission to draw over other apps.

Personally, i find this permission a bit intrusive, so i tried to find a different mechanism to start up a tunnel.
The new one uses a trick to start an activity completely invisible, and immediately move it to the backstack.

The only drawback that i found is that the quicktile-menu immediately disappears on clicking the tile, instead of slowly closing.

@newhinton
Copy link
Author

The abrupt disappearance of the quicktile-menu could be improved by providing an alternative layout to the TunnelToggleActivity which is only show when it was called by the quicktile.

Generally this is only an issue when the app was in background and no tunnel is available, otherwise the quicktile works as intended.

@newhinton
Copy link
Author

I have added a dummy-progressbar which will be shown in case the app was in background. It stays for 1000ms and then closes itself, after the tunnel has been triggered. This makes the transition way more visually pleasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant