Dxvk cleanup #2307
Open
Dxvk cleanup #2307
+47
−561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There likely isn't any reason for the common user to user use the pre 1.0 versions.
Even before they were fully removed in dxvk 2.0 they were not installed by default since 1.5.5. It is basically always recommended to use the Wine or Windows implementations of these and the dxvk one might break games.
They are not direct dependencies of dxvk and their inclusion in the dxvk verbs have lead to confusion
Blisto91
force-pushed
the
dxvk-cleanup
branch
from
b68fdd8
to
d15a9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things
Removes any pre dxvk 1.0 versions
It is unlikely that a regular user would ever need to use the very original pre release versions and so i thought it would make a nice cleanup to remove them.
Removes the installation of d3d10.dll and d3d10_1.dll
Even before their removal in dxvk 2.0 they were not installed by default in the old dxvk install script since version 1.5.5.
Their implementations were not complete and it was basically nearly always recommended to use either the Wine or Windows implementations. Using the dxvk ones could break some games.
The actual d3d10 implementation is in d3d10core while the two above are just helper libraries.
Removed the automatic installation of the d3dx9 and d3dcompiler libraries
Dxvk does not have a direct dependency on these and so doing a implicit install of them doesn't seem quite right and it has lead to confusion in the past. Bug reports have been made where a user think there was a dxvk regression because installing a older dxvk via winetricks fixed a bug even though it was because of the verb installing these libraies.
Imo it is better to just install these explicitly via their own verbs and not as a side effect of the dxvk one.