-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show first-introduced versions on roadmap #283
Conversation
This looks absolutely fantastic! |
This does look amazing! I can't do a proper review at the moment, could you ping me in a 3-4 days in case I forget? (others are welcome to review meanwhile, too) |
@RReverser ping~ |
Thanks, I built and played with this locally, and overall I like it a lot. Two notes:
|
Comments should be a lot clearer now. Accessibility is definitely an issue, but I'm somewhat unsure of how to go about it, mostly because of my lack of knowledge in this area. It's easy to make the cells focusable ( Initially I've considered showing a custom tooltip on hover/focus, like the references in Wikipedia and caniuse.com. But that would involve third-party libraries and generally be a great pain to implement. I tried highlighting the footnotes on focus, but the Anyway, it's midnight for me now. I will do more research on this tomorrow. |
8de4e96
to
171ce21
Compare
Done! I've implemented the custom tooltips and tested the accessibility with a screen reader. There should be no problem regarding that now. By the way, I used a JS feature from ES2020, which is supported by all browsers released after 2018 or 2019. Is that acceptable for this website or should I add a fallback for it? |
Awesome, thanks!
Perfectly acceptable, I don't think we should worry about older browsers on a developer-centric website. |
54.2 KiB -> 27.5 KiB Sources: * https://bytecodealliance.org/images/bytecode-alliance-logo.svg * https://commons.wikimedia.org/wiki/File:Google_Chrome_icon_(February_2022).svg * https://commons.wikimedia.org/wiki/File:Microsoft_Edge_logo_(2019).svg * https://commons.wikimedia.org/wiki/File:Firefox_logo,_2019.svg * https://nodejs.org/en/about/resources/ * https://commons.wikimedia.org/wiki/File:Safari_browser_logo.svg * https://wasmer.io/images/logo.svg
d6f040c
to
330b032
Compare
This looks amazing! What's needed to merge this PR? |
Me having a better memory 😅 I'll try it one more time locally now and hopefully merge after that. |
Left request for two small changes, the rest looks great! |
Ok I think we can always iterate on further a11y improvements in separate PRs, this already looks much better than what we had. Thanks again! |
This is a tentative implementation of the long-awaited feature proposed in #187.
https://webassembly.org/roadmap/
The initial data set is from this comment.
Closes #187.