Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TeacherProjectService): Move getBranchLetter to OneWorkgroupPerRowDataExportStrategy #1558

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

refactor(TeacherProjectService): Move getBranchLetter to OneWorkgroupPerRowDataExportStrategy #1558

wants to merge 1 commit into from
+42 −41

Conversation

hirokiterashima
Copy link
Member

Changes

  • Move TeacherProjectService.getBranchLetter() to OneWorkgroupPerRowDataExportStrategy.getBranchLetter(). OneWorkgroupPerRowDataExportStrategy was the only class that was calling this function.

Test

  • Export "One Workgroup per Row" for a run with a branch. Verify that the export has a "Branch Path Taken" column with the correct value

@hirokiterashima
refactor(TeacherProjectService): Move getBranchLetter to
0b5a325 
OneWorkgroupPerRowDataExportStrategy
@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Dec 12, 2023
@hirokiterashima hirokiterashima self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development 2023-2024
Status: Under Review
Milestone
Tech Debt 17 -> 16
Development

Successfully merging this pull request may close these issues.
1 participant
@hirokiterashima